SYaoJun commented on issue #846: URL: https://github.com/apache/incubator-graphar/issues/846#issuecomment-3871349819
> CC [@yangxk1](https://github.com/yangxk1) > > I have come up with 2 solutions: > > 1. Remove `empty_`, and require users to construct a `Vertex` with an `id` (this may be an API-breaking change). > 2. In `GetId()`, call `Empty()` first; if the vertex is empty, throw an exception. > > Any thoughts? I prefer the second solution. It avoids breaking changes to the API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
