SemyonSinchenko commented on code in PR #962: URL: https://github.com/apache/incubator-graphar/pull/962#discussion_r3831780656
########## .github/workflows/java-sdk.yml: ########## @@ -0,0 +1,78 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: GraphAr Java SDK CI + +on: + push: + branches: + - main + paths: + - 'maven-projects/pom.xml' + - 'maven-projects/storage-api/**' + - 'maven-projects/storage-local/**' + - 'maven-projects/io-api/**' + - 'maven-projects/io-parquet/**' + - 'maven-projects/core/**' + - 'maven-projects/reader/**' + - 'maven-projects/writer/**' + - '.github/workflows/java-sdk.yml' + pull_request: + branches: + - main + paths: + - 'maven-projects/pom.xml' + - 'maven-projects/storage-api/**' + - 'maven-projects/storage-local/**' + - 'maven-projects/io-api/**' + - 'maven-projects/io-parquet/**' + - 'maven-projects/core/**' + - 'maven-projects/reader/**' + - 'maven-projects/writer/**' + - '.github/workflows/java-sdk.yml' + +concurrency: + group: ${{ github.repository }}-${{ github.event.number || github.head_ref || github.sha }}-${{ github.workflow }} + cancel-in-progress: true + +jobs: + test: + runs-on: ubuntu-latest + env: + SDK_MODULES: storage-api + steps: + - uses: actions/checkout@v4 Review Comment: v7 is the latest; any specific reason to use v4? ########## .github/workflows/java-sdk.yml: ########## @@ -0,0 +1,78 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: GraphAr Java SDK CI + +on: + push: + branches: + - main + paths: + - 'maven-projects/pom.xml' + - 'maven-projects/storage-api/**' + - 'maven-projects/storage-local/**' + - 'maven-projects/io-api/**' + - 'maven-projects/io-parquet/**' + - 'maven-projects/core/**' + - 'maven-projects/reader/**' + - 'maven-projects/writer/**' + - '.github/workflows/java-sdk.yml' + pull_request: + branches: + - main + paths: + - 'maven-projects/pom.xml' + - 'maven-projects/storage-api/**' + - 'maven-projects/storage-local/**' + - 'maven-projects/io-api/**' + - 'maven-projects/io-parquet/**' + - 'maven-projects/core/**' + - 'maven-projects/reader/**' + - 'maven-projects/writer/**' + - '.github/workflows/java-sdk.yml' + +concurrency: + group: ${{ github.repository }}-${{ github.event.number || github.head_ref || github.sha }}-${{ github.workflow }} + cancel-in-progress: true + +jobs: + test: + runs-on: ubuntu-latest + env: + SDK_MODULES: storage-api + steps: + - uses: actions/checkout@v4 + with: + submodules: true + Review Comment: Let's add actions/cache@v6 based cache for maven and build. The cache key can be based on combination of os runner and, for example, pom.xml files hashes. Otherwise it will download dependencies each run and ASF Infra team won't be happy about it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
