keksmd commented on code in PR #962: URL: https://github.com/apache/incubator-graphar/pull/962#discussion_r3832723535
########## .github/workflows/java-sdk.yml: ########## @@ -0,0 +1,78 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: GraphAr Java SDK CI + +on: + push: + branches: + - main + paths: + - 'maven-projects/pom.xml' + - 'maven-projects/storage-api/**' + - 'maven-projects/storage-local/**' + - 'maven-projects/io-api/**' + - 'maven-projects/io-parquet/**' + - 'maven-projects/core/**' + - 'maven-projects/reader/**' + - 'maven-projects/writer/**' + - '.github/workflows/java-sdk.yml' + pull_request: + branches: + - main + paths: + - 'maven-projects/pom.xml' + - 'maven-projects/storage-api/**' + - 'maven-projects/storage-local/**' + - 'maven-projects/io-api/**' + - 'maven-projects/io-parquet/**' + - 'maven-projects/core/**' + - 'maven-projects/reader/**' + - 'maven-projects/writer/**' + - '.github/workflows/java-sdk.yml' + +concurrency: + group: ${{ github.repository }}-${{ github.event.number || github.head_ref || github.sha }}-${{ github.workflow }} + cancel-in-progress: true + +jobs: + test: + runs-on: ubuntu-latest + env: + SDK_MODULES: storage-api + steps: + - uses: actions/checkout@v4 Review Comment: No reason beyond copying the version the other workflows in this repo use. Bumped to `actions/checkout@v7` in c98e5e3. ########## .github/workflows/java-sdk.yml: ########## @@ -0,0 +1,78 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: GraphAr Java SDK CI + +on: + push: + branches: + - main + paths: + - 'maven-projects/pom.xml' + - 'maven-projects/storage-api/**' + - 'maven-projects/storage-local/**' + - 'maven-projects/io-api/**' + - 'maven-projects/io-parquet/**' + - 'maven-projects/core/**' + - 'maven-projects/reader/**' + - 'maven-projects/writer/**' + - '.github/workflows/java-sdk.yml' + pull_request: + branches: + - main + paths: + - 'maven-projects/pom.xml' + - 'maven-projects/storage-api/**' + - 'maven-projects/storage-local/**' + - 'maven-projects/io-api/**' + - 'maven-projects/io-parquet/**' + - 'maven-projects/core/**' + - 'maven-projects/reader/**' + - 'maven-projects/writer/**' + - '.github/workflows/java-sdk.yml' + +concurrency: + group: ${{ github.repository }}-${{ github.event.number || github.head_ref || github.sha }}-${{ github.workflow }} + cancel-in-progress: true + +jobs: + test: + runs-on: ubuntu-latest + env: + SDK_MODULES: storage-api + steps: + - uses: actions/checkout@v4 + with: + submodules: true + Review Comment: Added in c98e5e3: `actions/cache@v6` over `~/.m2/repository`, keyed on `${{ runner.os }}-maven-sdk-${{ hashFiles('maven-projects/**/pom.xml') }}` with a `${{ runner.os }}-maven-sdk-` restore prefix, so a run that changes no dependency restores instead of downloading. I left build output uncached on purpose: restoring `target/` between runs can hide a stale class from a clean build, and the dependency download is the part that costs Infra bandwidth. Happy to add it if you would rather have it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
