keksmd commented on PR #966:
URL:
https://github.com/apache/incubator-graphar/pull/966#issuecomment-5574261251
Follow-up: widening `SDK_MODULES` made the `Build Java Docs` step fail, and
I have fixed that in `ci(java): bind the javadoc step to a lifecycle phase`.
The step invoked the bare goal `mvn -pl ${SDK_MODULES} -am javadoc:javadoc`,
so the reactor produced no jars and `graphar-storage-local` tried to resolve
`graphar-storage-api:jar:0.13.0-SNAPSHOT` from the repository, where no
snapshot is published. With a single module in the list nothing was ever
resolved across modules, so the latent problem stayed invisible. Running
`package` in the same invocation makes the reactor supply the dependency.
Worth noting for a later cleanup, not changed here: the `verify` step
already runs `javadoc:jar (attach-javadocs)` for every module, so `Build Java
Docs` duplicates it. Happy to drop the step in a separate PR if you agree.
CI is green now, and the run actually exercised the new modules rather than
passing them by:
```
storage-api ...... SeekableInputTest 3/0/0
storage-local .... LocalStorageTest 5/0/0
io-api ........... 35 tests, 0 failures, 0 errors
storage-s3 ....... S3StorageTest 2/0/0
Build Java Docs .. all four modules SUCCESS
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
