keksmd commented on PR #966:
URL: 
https://github.com/apache/incubator-graphar/pull/966#issuecomment-5576288356

   Thanks @SemyonSinchenko for the review and the approval — the three points 
you raised are what made this module honest: typed failures on `headObject`, a 
`FileAlreadyExistsException` on the lost 412 race, and read-ahead so a 
byte-level reader no longer pays a round trip per `read()`.
   
   @SYaoJun your three points are addressed as well (CI now builds 
`storage-api,storage-local,io-api,storage-s3`, `create()` fast-fails at open 
time, canonical ASF headers), and the layer diagram in my earlier comment 
answers the design question about `info`. CI is green on `f1d0bb2` with real 
test counts: `S3StorageTest` 5/0/0, `io-api` 35/0/0, and `Build Java Docs` now 
succeeds for all five modules.
   
   Let me know if anything else is needed here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to