jerryshao commented on code in PR #4083:
URL: https://github.com/apache/gravitino/pull/4083#discussion_r1670146894
##########
catalogs/bundled-catalog/build.gradle.kts:
##########
@@ -85,6 +85,7 @@ tasks.withType<ShadowJar>(ShadowJar::class.java) {
exclude("NOTICE")
minimize()
+ relocate("com.datastrato.gravitino.catalog.lakehouse.iceberg",
"com.datastrato.gravitino.shaded.bundled.catalog.lakehouse.iceberg")
Review Comment:
I think this is not what bundled-catalog originally proposed to do, it is
weird to shade Iceberg catalog package in bundled-catalog.
With this, there may have two Gravitino Iceberg package, one shaded and one
not, will this lead to problem easily?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
