FANNG1 commented on code in PR #4083:
URL: https://github.com/apache/gravitino/pull/4083#discussion_r1670417968
##########
catalogs/bundled-catalog/build.gradle.kts:
##########
@@ -85,6 +85,7 @@ tasks.withType<ShadowJar>(ShadowJar::class.java) {
exclude("NOTICE")
minimize()
+ relocate("com.datastrato.gravitino.catalog.lakehouse.iceberg",
"com.datastrato.gravitino.shaded.bundled.catalog.lakehouse.iceberg")
Review Comment:
bundle catalog is used to provide the constants shared by connectors and
Gravitino catalogs. The current implementation used the constant from
`XXXPropertiesMetadata` and introduced the referred classes in
`bundle-catalog`, seems not proper, How about defining constant in `bundle
catalog` and `XXXPropertiesMetadata` rely on the constants?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
