mchades commented on code in PR #3461:
URL: https://github.com/apache/gravitino/pull/3461#discussion_r1677662522
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/ops/IcebergTableOpsHelper.java:
##########
@@ -143,7 +142,8 @@ private void doMoveColumn(
} else if (columnPosition instanceof TableChange.First) {
icebergUpdateSchema.moveFirst(DOT.join(fieldName));
} else {
- throw new NotSupportedException(
+ Preconditions.checkArgument(
+ columnPosition instanceof TableChange.Default,
Review Comment:
Does this change mean that if the user does not specify the column position,
nothing will happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
