mchades commented on code in PR #3461:
URL: https://github.com/apache/gravitino/pull/3461#discussion_r1678664343
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/ops/IcebergTableOpsHelper.java:
##########
@@ -143,7 +142,8 @@ private void doMoveColumn(
} else if (columnPosition instanceof TableChange.First) {
icebergUpdateSchema.moveFirst(DOT.join(fieldName));
} else {
- throw new NotSupportedException(
+ Preconditions.checkArgument(
+ columnPosition instanceof TableChange.Default,
Review Comment:
I noticed that this method is called in two places, one is `doAddColumn` and
the other is `doUpdateColumnPosition`. If it's called by
`doUpdateColumnPosition`, no changes will be made either. Are you sure this
meets expectations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
