FANNG1 commented on code in PR #4097:
URL: https://github.com/apache/gravitino/pull/4097#discussion_r1687348325


##########
flink-connector/src/main/java/org/apache/gravitino/flink/connector/catalog/BaseCatalog.java:
##########
@@ -470,6 +535,122 @@ private Column 
toGravitinoColumn(org.apache.flink.table.catalog.Column column) {
         null);
   }
 
+  private List<TableChange> optionsChanges(
+      Map<String, String> currentOptions, Map<String, String> updatedOptions) {
+    List<TableChange> optionsChanges = 
com.google.common.collect.Lists.newArrayList();

Review Comment:
   Gravitino may place some key like `Gravitino id` in table properties, I'm 
afraid this will remove the key.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to