coolderli commented on code in PR #4097:
URL: https://github.com/apache/gravitino/pull/4097#discussion_r1688001735
##########
flink-connector/src/main/java/org/apache/gravitino/flink/connector/catalog/BaseCatalog.java:
##########
@@ -470,6 +535,122 @@ private Column
toGravitinoColumn(org.apache.flink.table.catalog.Column column) {
null);
}
+ private List<TableChange> optionsChanges(
+ Map<String, String> currentOptions, Map<String, String> updatedOptions) {
+ List<TableChange> optionsChanges =
com.google.common.collect.Lists.newArrayList();
Review Comment:
I removed the option change in this function to provide it. The
`alterTable(ObjectPath tablePath, CatalogBaseTable newTable, boolean
ignoreIfNotExists) ` must be implemented. But for this function, it is hard to
get the TableChange.
```
void alterTable(ObjectPath tablePath, CatalogBaseTable newTable, boolean
ignoreIfNotExists)
default void alterTable(
ObjectPath tablePath,
CatalogBaseTable newTable,
List<TableChange> tableChanges,
boolean ignoreIfNotExists)
throws TableNotExistException, CatalogException {
alterTable(tablePath, newTable, ignoreIfNotExists);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
