jerqi commented on code in PR #4248:
URL: https://github.com/apache/gravitino/pull/4248#discussion_r1691048536


##########
docs/hadoop-catalog.md:
##########
@@ -63,7 +79,12 @@ Refer to [Schema 
operation](./manage-fileset-metadata-using-gravitino.md#schema-
 
 ### Fileset properties
 
-None.
+| Property name                                      | Description             
                                                                               
| Default value                | Required                                       
                                            | Since Version   |
+|----------------------------------------------------|--------------------------------------------------------------------------------------------------------|------------------------------|--------------------------------------------------------------------------------------------|-----------------|
+| `authentication.impersonation-enable`              | Whether to enable 
impersonation for the Hadoop catalog fileset.                                   
     | The parent's (catalog) value | No                                        
                                                 | 0.6.0           |
+| `authentication.type`                              | The type of 
authentication for Hadoop catalog fileset, currently we only support 
`kerberos`, `simple`. | The parent's (catalog) value | No                       
                                                                  | 0.6.0       
    |
+| `authentication.kerberos.principal`                | The principal of the 
Kerberos authentication for the fileset.                                        
  | The parent's (catalog) value | required if the value of 
`authentication.type` is Kerberos and parent hasn't set the value | 0.6.0       
    |

Review Comment:
   I mean that every authentication config options aren't required. Because 
they are extend from their parents. Only the oldest parent is required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to