yuqi1129 commented on code in PR #4248:
URL: https://github.com/apache/gravitino/pull/4248#discussion_r1695264892


##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/SecureHadoopCatalogOperations.java:
##########
@@ -231,6 +227,12 @@ public Fileset alterFileset(NameIdentifier ident, 
FilesetChange... changes)
       if (userInfo != null) {
         userInfoMap.put(NameIdentifier.of(ident.namespace(), finalName), 
userInfo);
       }
+
+      Boolean impersonationEnable = impersonationEnableMap.remove(ident);

Review Comment:
   Do you have any good suggestions? Using a map is just a way to calculate the 
real UGI and impersonation value by name identifier. What we can do is just 
combine them into one and use a class to hold these two map, I don't see any 
improvement or refinement for it, if you have better idea, please let me know, 
thanks.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to