jerryshao commented on code in PR #4262:
URL: https://github.com/apache/gravitino/pull/4262#discussion_r1699504251
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogPropertiesMetadata.java:
##########
@@ -41,7 +41,7 @@ public class HadoopCatalogPropertiesMetadata extends
BaseCatalogPropertiesMetada
PropertyEntry.stringOptionalPropertyEntry(
LOCATION,
"The storage location managed by Hadoop fileset catalog",
- true /* immutable */,
+ false /* immutable */,
Review Comment:
Do you test if it works or not if user changes this property?
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/authentication/AuthenticationConfig.java:
##########
@@ -95,10 +95,11 @@ public boolean isKerberosAuth() {
false))
.put(
AUTH_TYPE_KEY,
- PropertyEntry.stringImmutablePropertyEntry(
+ PropertyEntry.stringPropertyEntry(
Review Comment:
Should we use `stringOptionalPropertyEntry` here and below?
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogPropertiesMetadata.java:
##########
@@ -41,7 +41,7 @@ public class HadoopCatalogPropertiesMetadata extends
BaseCatalogPropertiesMetada
PropertyEntry.stringOptionalPropertyEntry(
LOCATION,
"The storage location managed by Hadoop fileset catalog",
- true /* immutable */,
+ false /* immutable */,
Review Comment:
I think you should have a IT to cover this.
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/authentication/kerberos/KerberosConfig.java:
##########
@@ -95,12 +95,18 @@ public int getFetchTimeoutSec() {
new ImmutableMap.Builder<String, PropertyEntry<?>>()
.put(
KEY_TAB_URI_KEY,
- PropertyEntry.stringImmutablePropertyEntry(
- KEY_TAB_URI_KEY, "The uri of key tab for the catalog",
false, null, false, false))
+ PropertyEntry.stringPropertyEntry(
+ KEY_TAB_URI_KEY,
+ "The uri of key tab for the catalog",
+ false,
Review Comment:
can you please cheange to this style `false /* xxx */`, better for reviewers
to understand which to which.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
