yuqi1129 commented on code in PR #4262:
URL: https://github.com/apache/gravitino/pull/4262#discussion_r1699518416
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogPropertiesMetadata.java:
##########
@@ -41,7 +41,7 @@ public class HadoopCatalogPropertiesMetadata extends
BaseCatalogPropertiesMetada
PropertyEntry.stringOptionalPropertyEntry(
LOCATION,
"The storage location managed by Hadoop fileset catalog",
- true /* immutable */,
+ false /* immutable */,
Review Comment:
> Do you test if it works or not if user changes this property?
Yes, I verify it locally.
> I think you should have a IT to cover this.
Okay, a similar IT has been added for the Hive catalog, I will add some
tests for it.
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogPropertiesMetadata.java:
##########
@@ -88,10 +88,11 @@ public class IcebergCatalogPropertiesMetadata extends
BaseCatalogPropertiesMetad
static {
List<PropertyEntry<?>> propertyEntries =
ImmutableList.of(
- enumImmutablePropertyEntry(
+ enumPropertyEntry(
CATALOG_BACKEND,
"Iceberg catalog type choose properties",
true,
+ false,
Review Comment:
What if a user mistakenly write `Hive` with `hiev`?
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogPropertiesMetadata.java:
##########
@@ -88,10 +88,11 @@ public class IcebergCatalogPropertiesMetadata extends
BaseCatalogPropertiesMetad
static {
List<PropertyEntry<?>> propertyEntries =
ImmutableList.of(
- enumImmutablePropertyEntry(
+ enumPropertyEntry(
CATALOG_BACKEND,
"Iceberg catalog type choose properties",
true,
+ false,
Review Comment:
What if the user mistakenly write `HIVE` to `HIEV`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
