jerryshao commented on code in PR #4281: URL: https://github.com/apache/gravitino/pull/4281#discussion_r1705029589
########## api/src/main/java/org/apache/gravitino/file/FilesetDataOperationCtx.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.file; + +import org.apache.gravitino.annotation.Evolving; + +/** + * An interface representing a fileset data operation context. This interface defines some + * information need to report to the server. + * + * <p>{@link FilesetDataOperationCtx} defines the basic properties of a fileset data operation + * context object. + */ +@Evolving +public interface FilesetDataOperationCtx { + /** @return The sub path which is operated by the data operation . */ + String subPath(); + + /** @return The data operation type. */ + FilesetDataOperation operation(); + + /** @return The client type of the data operation. */ + ClientType clientType(); +} Review Comment: I understand the purpose of adding a new interface, what I'm thinking about is not just the `FileContext` API, I was thinking how to design this in a user-friendly way. The current interface here is a little hard for user to understand its purpose and usage. I'm more concerned about this, can you please write a document about how you design this, either in the current way, or using `map`, or even using caller context. And we can discuss based on this. Overall, I think we should be more cautious when the changes involves API definitions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
