diqiu50 commented on code in PR #4420:
URL: https://github.com/apache/gravitino/pull/4420#discussion_r1708377848
##########
catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/MySQLProtocolCompatibleCatalogOperations.java:
##########
@@ -47,6 +49,18 @@ public MySQLProtocolCompatibleCatalogOperations(
columnDefaultValueConverter);
}
+ @Override
+ public boolean checkJDBCDriverVersion() {
+ JDBCDriverInfo driverInfo = getDiverInfo();
+ if (driverInfo.majorVersion < MYSQL_JDBC_DRIVER_MINIMAL_SUPPORT_VERSION) {
Review Comment:
Yes, I found that our source code only uses the MySQL driver 8.x. Do you
think we still need to consider version 5.x. If we test one by one, it will be
quite time-consuming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
