diqiu50 commented on code in PR #4420:
URL: https://github.com/apache/gravitino/pull/4420#discussion_r1708724339
##########
catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/MySQLProtocolCompatibleCatalogOperations.java:
##########
@@ -47,6 +49,18 @@ public MySQLProtocolCompatibleCatalogOperations(
columnDefaultValueConverter);
}
+ @Override
+ public boolean checkJDBCDriverVersion() {
+ JDBCDriverInfo driverInfo = getDiverInfo();
+ if (driverInfo.majorVersion < MYSQL_JDBC_DRIVER_MINIMAL_SUPPORT_VERSION) {
Review Comment:
I think we can restrict support for major versions like 5.x. For minor
versions within 8.0, if there are bugs, we should fix them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
