yuqi1129 commented on PR #4232: URL: https://github.com/apache/gravitino/pull/4232#issuecomment-2275143733
> > > https://github.com/apache/gravitino/blob/13f3b3f3118e2a7f8b63aa324e11c688159f4633/catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/SecureHadoopCatalogOperations.java#L92-L94 > > > > > > I wonder why the passed value to hadoop conf is `null` in places like this. In this way, we can not pass some configurations in schema/fileset level. Should we use `hadoopCatalogOperations.getHadoopConf()` instead? > > > > > > We can't pass the Hadoop Conf from the method signature, so I use null instead. If you need the value, please go ahead and make the necessary changes. > > After thinking carefully, I'm not sure whether it is appropriate to support multi-level authentication for S3. Because we have to pass some configurations to hadoop conf when doing some operations on schema/fileset, but the `hadoopConf` in `HadoopCatalogOperations` is defined at catalog level, if we want to modify it, we have to lock `hadoopConf` to avoid conflicts, which means we cannot do some operations at same time(like creating two different schemas at one catalog). Do you have any suggestions? @yuqi1129 We can start with catalog-level authentication first, when there is a clear need to support multiple-level authentication for S3, we can do it again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
