FANNG1 commented on code in PR #4395:
URL: https://github.com/apache/gravitino/pull/4395#discussion_r1711221392
##########
iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/integration/test/IcebergRESTServiceBaseIT.java:
##########
@@ -86,7 +86,7 @@ private void registerIcebergCatalogConfig() {
LOG.info("Iceberg REST service config registered, {}",
StringUtils.join(icebergConfigs));
}
- private int getServerPort() {
+ protected int getServerPort() {
Review Comment:
no need to change?
##########
iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/integration/test/IcebergRESTServiceIT.java:
##########
@@ -69,7 +69,7 @@ private void purgeNameSpace(String namespace) {
sql("DROP database " + namespace);
}
- private void purgeAllIcebergTestNamespaces() {
Review Comment:
no need to change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
