FANNG1 commented on code in PR #4395:
URL: https://github.com/apache/gravitino/pull/4395#discussion_r1716253483


##########
docs/iceberg-rest-service.md:
##########
@@ -121,32 +121,46 @@ The Gravitino Iceberg REST catalog service uses the 
memory catalog backend by de
 
 #### Apache Hive backend configuration
 
-| Configuration item                            | Description                  
                                                                                
                                | Default value                                 
                                | Required | Since Version |
-|-----------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------|----------|---------------|
-| `gravitino.iceberg-rest.catalog-backend`      | The Catalog backend of the 
Gravitino Iceberg REST catalog service. Use the value **`hive`** for a Hive 
catalog.                              | `memory`                                
                                      | Yes      | 0.2.0         |
-| `gravitino.iceberg-rest.uri`                  | The Hive metadata address, 
such as `thrift://127.0.0.1:9083`.                                              
                                  | (none)                                      
                                  | Yes      | 0.2.0         |
-| `gravitino.iceberg-rest.warehouse`            | The warehouse directory of 
the Hive catalog, such as `/user/hive/warehouse-hive/`.                         
                                  | (none)                                      
                                  | Yes      | 0.2.0         |
-| `gravitino.iceberg-rest.catalog-backend-name` | The catalog backend name 
passed to underlying Iceberg catalog backend. Catalog name in JDBC backend is 
used to isolate namespace and tables. | `hive` for Hive backend, `jdbc` for 
JDBC backend, `memory` for memory backend | No       | 0.5.2         |
+| Configuration item                                                        | 
Description                                                                     
                                                             | Default value    
                                                              | Required | 
Since Version |
+|---------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------|--------------------------------------------------------------------------------|----------|---------------|
+| `gravitino.iceberg-rest.catalog-backend`                                  | 
The Catalog backend of the Gravitino Iceberg REST catalog service. Use the 
value **`hive`** for a Hive catalog.                              | `memory`    
                                                                   | Yes      | 
0.2.0         |
+| `gravitino.iceberg-rest.uri`                                              | 
The Hive metadata address, such as `thrift://127.0.0.1:9083`.                   
                                                             | (none)           
                                                              | Yes      | 
0.2.0         |
+| `gravitino.iceberg-rest.warehouse`                                        | 
The warehouse directory of the Hive catalog, such as 
`/user/hive/warehouse-hive/`.                                                   
        | (none)                                                                
         | Yes      | 0.2.0         |
+| `gravitino.iceberg-rest.catalog-backend-name`                             | 
The catalog backend name passed to underlying Iceberg catalog backend. Catalog 
name in JDBC backend is used to isolate namespace and tables. | `hive` for Hive 
backend, `jdbc` for JDBC backend, `memory` for memory backend  | No       | 
0.5.2         |
 
 #### JDBC backend configuration
 
-| Configuration item                            | Description                  
                                                                                
                        | Default value           | Required | Since Version |
-|-----------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------|-------------------------|----------|---------------|
-| `gravitino.iceberg-rest.catalog-backend`      | The Catalog backend of the 
Gravitino Iceberg REST catalog service. Use the value **`jdbc`** for a JDBC 
catalog.                      | `memory`                | Yes      | 0.2.0      
   |
-| `gravitino.iceberg-rest.uri`                  | The JDBC connection address, 
such as `jdbc:postgresql://127.0.0.1:5432` for Postgres, or 
`jdbc:mysql://127.0.0.1:3306/` for mysql.   | (none)                  | Yes     
 | 0.2.0         |
-| `gravitino.iceberg-rest.warehouse `           | The warehouse directory of 
JDBC catalog. Set the HDFS prefix if using HDFS, such as 
`hdfs://127.0.0.1:9000/user/hive/warehouse-jdbc` | (none)                  | 
Yes      | 0.2.0         |
-| `gravitino.iceberg-rest.catalog-backend-name` | The catalog name passed to 
underlying Iceberg catalog backend. Catalog name in JDBC backend is used to 
isolate namespace and tables. | `jdbc` for JDBC backend | No       | 0.5.2      
   |
-| `gravitino.iceberg-rest.jdbc.user`            | The username of the JDBC 
connection.                                                                     
                            | (none)                  | Yes      | 0.2.0        
 |
-| `gravitino.iceberg-rest.jdbc.password`        | The password of the JDBC 
connection.                                                                     
                            | (none)                  | Yes      | 0.2.0        
 |
-| `gravitino.iceberg-rest.jdbc-initialize`      | Whether to initialize the 
meta tables when creating the JDBC catalog.                                     
                           | `true`                  | No       | 0.2.0         
|
-| `gravitino.iceberg-rest.jdbc-driver`          | `com.mysql.jdbc.Driver` or 
`com.mysql.cj.jdbc.Driver` for MySQL, `org.postgresql.Driver` for PostgreSQL.   
                          | (none)                  | Yes      | 0.3.0         |
+| Configuration item                                                        | 
Description                                                                     
                                                      | Default value           
 | Required | Since Version |
+|---------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------|--------------------------|----------|---------------|
+| `gravitino.iceberg-rest.catalog-backend`                                  | 
The Catalog backend of the Gravitino Iceberg REST catalog service. Use the 
value **`jdbc`** for a JDBC catalog.                       | `memory`           
      | Yes      | 0.2.0         |
+| `gravitino.iceberg-rest.uri`                                              | 
The JDBC connection address, such as `jdbc:postgresql://127.0.0.1:5432` for 
Postgres, or `jdbc:mysql://127.0.0.1:3306/` for mysql.    | (none)              
     | Yes      | 0.2.0         |
+| `gravitino.iceberg-rest.warehouse `                                       | 
The warehouse directory of JDBC catalog. Set the HDFS prefix if using HDFS, 
such as `hdfs://127.0.0.1:9000/user/hive/warehouse-jdbc`  | (none)              
     | Yes      | 0.2.0         |
+| `gravitino.iceberg-rest.catalog-backend-name`                             | 
The catalog name passed to underlying Iceberg catalog backend. Catalog name in 
JDBC backend is used to isolate namespace and tables.  | `jdbc` for JDBC 
backend  | No       | 0.5.2         |
+| `gravitino.iceberg-rest.jdbc.user`                                        | 
The username of the JDBC connection.                                            
                                                      | (none)                  
 | Yes      | 0.2.0         |
+| `gravitino.iceberg-rest.jdbc.password`                                    | 
The password of the JDBC connection.                                            
                                                      | (none)                  
 | Yes      | 0.2.0         |
+| `gravitino.iceberg-rest.jdbc-initialize`                                  | 
Whether to initialize the meta tables when creating the JDBC catalog.           
                                                      | `true`                  
 | No       | 0.2.0         |
+| `gravitino.iceberg-rest.jdbc-driver`                                      | 
`com.mysql.jdbc.Driver` or `com.mysql.cj.jdbc.Driver` for MySQL, 
`org.postgresql.Driver` for PostgreSQL.                              | (none)   
                | Yes      | 0.3.0         |
 
 If you have a JDBC Iceberg catalog prior, you must set `catalog-backend-name` 
to keep consistent with your Jdbc Iceberg catalog name to operate the prior 
namespace and tables.
 
 :::caution
 You must download the corresponding JDBC driver to the 
`iceberg-rest-server/libs` directory.
 :::
 
+#### Backend authentication

Review Comment:
   Could you move this to `Security` section?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to