FANNG1 commented on code in PR #4273: URL: https://github.com/apache/gravitino/pull/4273#discussion_r1713135631
##########
docs/iceberg-rest-service.md:
##########
@@ -65,18 +65,19 @@ Please note that, it only takes affect in `gravitino.conf`,
you don't need to sp
### REST catalog server configuration
-| Configuration item | Description
| Default value
| Required | Since
Version |
-|--------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------|----------|---------------|
-| `gravitino.iceberg-rest.host` | The host of the Gravitino
Iceberg REST catalog service.
| `0.0.0.0`
| No | 0.2.0
|
-| `gravitino.iceberg-rest.httpPort` | The port of the Gravitino
Iceberg REST catalog service.
| `9001`
| No | 0.2.0
|
-| `gravitino.iceberg-rest.minThreads` | The minimum number of
threads in the thread pool used by the Jetty web server. `minThreads` is 8 if
the value is less than 8.
|
`Math.max(Math.min(Runtime.getRuntime().availableProcessors() * 2, 100), 8)` |
No | 0.2.0 |
-| `gravitino.iceberg-rest.maxThreads` | The maximum number of
threads in the thread pool used by the Jetty web server. `maxThreads` is 8 if
the value is less than 8, and `maxThreads` must be greater than or equal to
`minThreads`. |
`Math.max(Runtime.getRuntime().availableProcessors() * 4, 400)` |
No | 0.2.0 |
-| `gravitino.iceberg-rest.threadPoolWorkQueueSize` | The size of the queue in
the thread pool used by Gravitino Iceberg REST catalog service.
| `100`
| No | 0.2.0
|
-| `gravitino.iceberg-rest.stopTimeout` | The amount of time in ms
for the Gravitino Iceberg REST catalog service to stop gracefully. For more
information, see `org.eclipse.jetty.server.Server#setStopTimeout`.
| `30000`
| No |
0.2.0 |
-| `gravitino.iceberg-rest.idleTimeout` | The timeout in ms of idle
connections.
| `30000`
| No | 0.2.0
|
-| `gravitino.iceberg-rest.requestHeaderSize` | The maximum size of an
HTTP request.
| `131072`
| No | 0.2.0
|
-| `gravitino.iceberg-rest.responseHeaderSize` | The maximum size of an
HTTP response.
| `131072`
| No | 0.2.0
|
-| `gravitino.iceberg-rest.customFilters` | Comma-separated list of
filter class names to apply to the APIs.
| (none)
| No | 0.4.0
|
+| Configuration item | Description
| Default value
| Required | Since Version |
+|--------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------|----------|---------------|
+| `gravitino.iceberg-rest.host` | The host of the Gravitino
Iceberg REST catalog service.
| `0.0.0.0`
| No | 0.2.0 |
+| `gravitino.iceberg-rest.httpPort` | The port of the Gravitino
Iceberg REST catalog service.
| `9001`
| No | 0.2.0 |
+| `gravitino.iceberg-rest.minThreads` | The minimum number of
threads in the thread pool used by the Jetty web server. `minThreads` is 8 if
the value is less than 8.
|
`Math.max(Math.min(Runtime.getRuntime().availableProcessors() * 2, 100), 8)` |
No | 0.2.0 |
+| `gravitino.iceberg-rest.maxThreads` | The maximum number of
threads in the thread pool used by the Jetty web server. `maxThreads` is 8 if
the value is less than 8, and `maxThreads` must be greater than or equal to
`minThreads`. |
`Math.max(Runtime.getRuntime().availableProcessors() * 4, 400)` |
No | 0.2.0 |
+| `gravitino.iceberg-rest.threadPoolWorkQueueSize` | The size of the queue in
the thread pool used by Gravitino Iceberg REST catalog service.
| `100`
| No | 0.2.0 |
+| `gravitino.iceberg-rest.stopTimeout` | The amount of time in ms
for the Gravitino Iceberg REST catalog service to stop gracefully. For more
information, see `org.eclipse.jetty.server.Server#setStopTimeout`.
| `30000`
| No | 0.2.0 |
+| `gravitino.iceberg-rest.idleTimeout` | The timeout in ms of idle
connections.
| `30000`
| No | 0.2.0 |
+| `gravitino.iceberg-rest.requestHeaderSize` | The maximum size of an
HTTP request.
| `131072`
| No | 0.2.0 |
+| `gravitino.iceberg-rest.responseHeaderSize` | The maximum size of an
HTTP response.
| `131072`
| No | 0.2.0 |
+| `gravitino.iceberg-rest.customFilters` | Comma-separated list of
filter class names to apply to the APIs.
| (none)
| No | 0.4.0 |
+| `gravitino.iceberg-rest.catalog-provider-impl` | The implementation of
IcebergTableOpsProvider defines how the Iceberg REST catalog server gets
iceberg catalogs.
|
`org.apache.gravitino.iceberg.common.ops.ConfigIcebergTableOpsProvider` |
No | 0.6.0 |
Review Comment:
the other config items are for HTTP servers, it's better to create a new
section like `Multi catalog`, and provide an example about how to configuration
multi catalogs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
