FANNG1 commented on code in PR #4273:
URL: https://github.com/apache/gravitino/pull/4273#discussion_r1713254708
##########
docs/iceberg-rest-service.md:
##########
@@ -147,6 +147,26 @@ If you have a JDBC Iceberg catalog prior, you must set
`catalog-backend-name` to
You must download the corresponding JDBC driver to the
`iceberg-rest-server/libs` directory.
:::
+#### Multi catalog support
+| Configuration item | Description
| Default value
| Required | Since Version |
+|--------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------|----------|---------------|
+| `gravitino.iceberg-rest.catalog-provider-impl` | The implementation of
IcebergTableOpsProvider defines how the Iceberg REST catalog server gets
iceberg catalogs. |
`org.apache.gravitino.iceberg.common.ops.ConfigBasedIcebergTableOpsProvider`
| No | 0.6.0 |
+
+You can also specify catalog parameters by setting configuration entries in
the style `gravitino.iceberg-rest.catalog.<catalog name>.<param name>=<value>`.
+
+For example, we can configure two different catalogs named `hive_backend` and
`jdbc_backend`.
Review Comment:
this only take affects when it's conf based xx
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/IcebergConfig.java:
##########
@@ -158,6 +158,15 @@ public class IcebergConfig extends Config implements
OverwriteDefaultConfig {
.stringConf()
.create();
+ public static final ConfigEntry<String> ICEBERG_REST_CATALOG_PROVIDER =
+ new ConfigBuilder(IcebergConstants.ICEBERG_REST_CATALOG_PROVIDER)
+ .doc(
+ "The implementation of IcebergTableOpsProvider defines how the
Iceberg REST catalog server gets iceberg catalogs.")
Review Comment:
iceberg -> Iceberg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
