yuqi1129 commented on code in PR #4395:
URL: https://github.com/apache/gravitino/pull/4395#discussion_r1716257046
##########
iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/integration/test/util/IcebergRESTServerManagerForDeploy.java:
##########
@@ -51,12 +55,39 @@ public Optional<Future<?>> doStartIcebergRESTServer()
throws Exception {
SQLITE_DRIVER_DOWNLOAD_URL,
Paths.get(icebergRESTServerHome.toString(), "iceberg-rest-server",
"libs").toString());
- String cmd = String.format("%s/bin/%s start",
icebergRESTServerHome.toString(), SCRIPT_NAME);
- CommandExecutor.executeCommandLocalHost(
- cmd,
- false,
- ProcessData.TypesOfData.OUTPUT,
- ImmutableMap.of("GRAVITINO_HOME", icebergRESTServerHome.toString()));
+ String gravitinoRestStartShell = icebergRESTServerHome.toString() +
"/bin/" + SCRIPT_NAME;
Review Comment:
Do you mean we need to remove this code block? I'm afraid not, removing it
will make Iceberg REST server start failed when using Kerberos Hive backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
