jerryshao commented on code in PR #4631:
URL: https://github.com/apache/gravitino/pull/4631#discussion_r1726975362


##########
docs/iceberg-rest-service.md:
##########
@@ -117,7 +117,7 @@ Gravitino Iceberg REST service supports using static 
access-key-id and secret-ac
 For other Iceberg s3 properties not managed by Gravitino like `s3.sse.type`, 
you could config it directly by `gravitino.iceberg-rest.s3.sse.type`.
 
 :::info
-Please set `gravitino.iceberg-rest.warehouse` to 
`s3://{bucket_name}/${prefix_name}` for Jdbc catalog backend, 
`s3a://{bucket_name}/${prefix_name}` for Hive catalog backend.
+Please set `gravitino.iceberg-rest.warehouse` to 
`s3://{bucket_name}/${prefix_name}` for Jdbc catalog backend, 
`s3a://{bucket_name}/${prefix_name}` for Hive catalog backend and download 
[Iceberg AWS 
bundle](https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-aws-bundle)
 and place it to the classpath of Iceberg REST server.

Review Comment:
   There're 3 things mixed in one sentence, which makes me so confused, 1) 
about jdbc backend, 2) about hive backend, 3) about aws bundle. You'd better 
separate into 3 sentence, and describe it more clearly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to