FANNG1 commented on code in PR #4631: URL: https://github.com/apache/gravitino/pull/4631#discussion_r1727098308
########## docs/spark-connector/spark-catalog-iceberg.md: ########## @@ -97,44 +97,29 @@ DESC EXTENDED employee; For more details about `CALL`, please refer to the [Spark Procedures description](https://iceberg.apache.org/docs/1.5.2/spark-procedures/#spark-procedures) in Iceberg official document. -## Apache Iceberg catalog backend support -- HiveCatalog -- JdbcCatalog -- RESTCatalog - -### Catalog properties +## Catalog properties Gravitino spark connector will transform below property names which are defined in catalog properties to Spark Iceberg connector configuration. -#### HiveCatalog - -| Gravitino catalog property name | Spark Iceberg connector configuration | Default Value | Required | Description | Since Version | -|---------------------------------|---------------------------------------|---------------|----------|---------------------------|---------------| -| `catalog-backend` | `type` | `memory` | Yes | Catalog backend type | 0.5.0 | -| `uri` | `uri` | (none) | Yes | Catalog backend uri | 0.5.0 | -| `warehouse` | `warehouse` | (none) | Yes | Catalog backend warehouse | 0.5.0 | - -#### JdbcCatalog - -| Gravitino catalog property name | Spark Iceberg connector configuration | Default Value | Required | Description | Since Version | -|---------------------------------|---------------------------------------|---------------|----------|---------------------------|---------------| -| `catalog-backend` | `type` | `memory` | Yes | Catalog backend type | 0.5.0 | -| `uri` | `uri` | (none) | Yes | Catalog backend uri | 0.5.0 | -| `warehouse` | `warehouse` | (none) | Yes | Catalog backend warehouse | 0.5.0 | -| `jdbc-user` | `jdbc.user` | (none) | Yes | JDBC user name | 0.5.0 | -| `jdbc-password` | `jdbc.password` | (none) | Yes | JDBC password | 0.5.0 | +| Gravitino catalog property name | Spark Iceberg connector configuration | Description | Since Version | +|---------------------------------|---------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------| +| `catalog-backend` | `type` | Catalog backend type | 0.5.0 | +| `uri` | `uri` | Catalog backend uri | 0.5.0 | +| `warehouse` | `warehouse` | Catalog backend warehouse | 0.5.0 | +| `jdbc-user` | `jdbc.user` | JDBC user name | 0.5.0 | +| `jdbc-password` | `jdbc.password` | JDBC password | 0.5.0 | +| `io-impl` | `io-impl` | The io implementation for `FileIO` in Iceberg. | 0.6.0 | +| `s3-endpoint` | `s3.endpoint` | An alternative endpoint of the S3 service, This could be used for S3FileIO with any s3-compatible object storage service that has a different endpoint, or access a private S3 endpoint in a virtual private cloud. | 0.6.0 | Review Comment: S3 had a global endpoint, and user doesn't need to set it by default -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
