jerryshao commented on code in PR #4651:
URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730748521
##########
catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/JdbcCatalogPropertiesMetadata.java:
##########
@@ -94,7 +95,11 @@ public class JdbcCatalogPropertiesMetadata extends
BaseCatalogPropertiesMetadata
JdbcConfig.POOL_MAX_SIZE.getDefaultValue(),
true /* hidden */,
false /* reserved */));
- PROPERTIES_METADATA = Maps.uniqueIndex(propertyEntries,
PropertyEntry::getName);
+ PROPERTIES_METADATA =
+ ImmutableMap.<String, PropertyEntry<?>>builder()
+ .putAll(BASIC_CATALOG_PROPERTY_ENTRIES)
+ .putAll(Maps.uniqueIndex(propertyEntries, PropertyEntry::getName))
+ .build();
Review Comment:
@yuqi1129 can you please check this part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
