jerryshao commented on code in PR #4651:
URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730749137
##########
catalogs/catalog-kafka/src/main/java/org/apache/gravitino/catalog/kafka/KafkaCatalogPropertiesMetadata.java:
##########
@@ -30,13 +30,17 @@ public class KafkaCatalogPropertiesMetadata extends
BaseCatalogPropertiesMetadat
public static final String BOOTSTRAP_SERVERS = "bootstrap.servers";
private static final Map<String, PropertyEntry<?>>
KAFKA_CATALOG_PROPERTY_ENTRIES =
- Collections.singletonMap(
- BOOTSTRAP_SERVERS,
- PropertyEntry.stringRequiredPropertyEntry(
+ ImmutableMap.<String, PropertyEntry<?>>builder()
+ .put(
BOOTSTRAP_SERVERS,
- "The Kafka broker(s) to connect to, allowing for multiple
brokers by comma-separating them",
- false /* immutable */,
- false /* hidden */));
+ PropertyEntry.stringRequiredPropertyEntry(
+ BOOTSTRAP_SERVERS,
+ "The Kafka broker(s) to connect to, allowing for multiple
brokers by "
+ + "comma-separating them",
+ false /* immutable */,
+ false /* hidden */))
+ .putAll(BASIC_CATALOG_PROPERTY_ENTRIES)
+ .build();
Review Comment:
@mchades can you please check this part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
