FANNG1 commented on code in PR #4896:
URL: https://github.com/apache/gravitino/pull/4896#discussion_r1754412283


##########
docs/iceberg-rest-service.md:
##########
@@ -321,7 +332,7 @@ For example, we can configure Spark catalog options to use 
Gravitino Iceberg RES
 --conf spark.sql.catalog.rest.uri=http://127.0.0.1:9001/iceberg/
 ```
 
-You may need to adjust the Iceberg Spark runtime jar file name according to 
the real version number in your environment. If you want to access the data 
stored in S3, you need to download [Iceberg AWS 
bundle](https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-aws-bundle)
 jar and place it in the classpath of Spark, no extra config is needed because 
S3 related properties is transferred from Iceberg REST server to Iceberg REST 
client automaticly. 
+You may need to adjust the Iceberg Spark runtime jar file name according to 
the real version number in your environment. If you want to access the data 
stored in S3, you need to download [Iceberg AWS 
bundle](https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-aws-bundle)
 jar and place it in the classpath of Spark, no extra config is needed because 
S3 related properties is transferred from Iceberg REST server to Iceberg REST 
client automaticly. For other storages not managed by Gravitino, you could 
specify the configuration explicitly to initialize the `FileIO` implementation, 
like `spark.sql.catalog.${catalog_name}.${configuration_key}`.

Review Comment:
   updated



##########
docs/iceberg-rest-service.md:
##########
@@ -138,6 +135,20 @@ For other Iceberg OSS properties not managed by Gravitino 
like `client.security-
 Please set the `gravitino.iceberg-rest.warehouse` parameter to 
`oss://{bucket_name}/${prefix_name}`. Additionally, download the [Aliyun OSS 
SDK](https://gosspublic.alicdn.com/sdks/java/aliyun_java_sdk_3.10.2.zip) and 
copy `aliyun-sdk-oss-3.10.2.jar`, `hamcrest-core-1.1.jar`, `jdom2-2.0.6.jar` in 
the classpath of Iceberg REST server, `iceberg-rest-server/libs` for the 
auxiliary server, `libs` for the standalone server.
 :::
 
+#### Other storages
+
+For storages that are not inherently integrated into Gravitino Iceberg REST 
service, you can manage them effectively through custom catalog properties.
+
+| Configuration item               | Description                               
                                              | Default value | Required | 
Since Version |
+|----------------------------------|-----------------------------------------------------------------------------------------|---------------|----------|---------------|
+| `gravitino.iceberg-rest.io-impl` | The IO implementation for `FileIO` in 
Iceberg, please use the full qualified classname. | (none)        | No       | 
0.6.0         |
+
+For other custom properties like `security-token` to pass to `FileIO`, you 
could config it directly by `gravitino.iceberg-rest.security-token`.

Review Comment:
   updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to