FANNG1 commented on code in PR #4896: URL: https://github.com/apache/gravitino/pull/4896#discussion_r1755912686
########## docs/iceberg-rest-service.md: ########## @@ -18,10 +18,7 @@ The Apache Gravitino Iceberg REST Server follows the [Apache Iceberg REST API sp - multi table transaction - pagination - Works as a catalog proxy, supporting `Hive` and `JDBC` as catalog backend. -- Supports multi storage. - - HDFS - - S3 - - OSS +- Supports diverse storage like `S3`, `HDFS`, `OSS`, and provides the capability to support other storages. Review Comment: using `Supports different storages`, because HDFS is not cloud storage ########## docs/iceberg-rest-service.md: ########## @@ -337,7 +348,7 @@ For example, we can configure Spark catalog options to use Gravitino Iceberg RES --conf spark.sql.catalog.rest.uri=http://127.0.0.1:9001/iceberg/ ``` -You may need to adjust the Iceberg Spark runtime jar file name according to the real version number in your environment. If you want to access the data stored in cloud, you need to download corresponding jars (please refer to the cloud storage part) and place it in the classpath of Spark, no extra config is needed because related properties is transferred from Iceberg REST server to Iceberg REST client automatically. +You may need to adjust the Iceberg Spark runtime jar file name according to the real version number in your environment. If you want to access the data stored in cloud, you need to download corresponding jars (please refer to the cloud storage part) and place it in the classpath of Spark, no extra config is needed because related properties is transferred from Iceberg REST server to Iceberg REST client automatically. For other storages not managed by Gravitino, the properties wouldn't transfer from the server to client automatically, if you want to pass custom properties to initialize `FileIO`, you could add it by `spark.sql.catalog.${iceberg_catalog_name}.${configuration_key}` = `{property_value}`. Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
