jerqi commented on code in PR #4894:
URL: https://github.com/apache/gravitino/pull/4894#discussion_r1775106796


##########
core/src/main/java/org/apache/gravitino/storage/relational/service/RoleMetaService.java:
##########
@@ -237,6 +239,26 @@ private List<SecurableObjectPO> 
listSecurableObjectsByRoleId(Long roleId) {
         SecurableObjectMapper.class, mapper -> 
mapper.listSecurableObjectsByRoleId(roleId));
   }
 
+  public List<RoleEntity> listRolesByNamespace(Namespace namespace, boolean 
allFields) {
+    AuthorizationUtils.checkRoleNamespace(namespace);
+    String metalakeName = namespace.level(0);
+
+    if (allFields) {
+      throw new IllegalArgumentException("Don't support list all the fields of 
roles");
+    }

Review Comment:
   OK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to