jerryshao commented on code in PR #4894:
URL: https://github.com/apache/gravitino/pull/4894#discussion_r1775198116
##########
common/src/main/java/org/apache/gravitino/dto/authorization/RoleDTO.java:
##########
@@ -186,9 +192,6 @@ public S withAudit(AuditDTO audit) {
public RoleDTO build() {
Preconditions.checkArgument(StringUtils.isNotBlank(name), "name cannot
be null or empty");
Preconditions.checkArgument(audit != null, "audit cannot be null");
- Preconditions.checkArgument(
- securableObjects != null && securableObjects.length != 0,
- "securable objects can't null or empty");
Review Comment:
Is it still removable, or should be checked?
##########
common/src/main/java/org/apache/gravitino/dto/responses/RoleResponse.java:
##########
@@ -64,8 +64,5 @@ public void validate() throws IllegalArgumentException {
Preconditions.checkArgument(
StringUtils.isNotBlank(role.name()), "role 'name' must not be null and
empty");
Preconditions.checkArgument(role.auditInfo() != null, "role 'auditInfo'
must not be null");
- Preconditions.checkArgument(
- role.securableObjects() != null && !role.securableObjects().isEmpty(),
- "role 'securableObjects' can't null or empty");
Review Comment:
Is it still removable, or should be checked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
