yuqi1129 commented on code in PR #4996:
URL: https://github.com/apache/gravitino/pull/4996#discussion_r1796390829
##########
trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryITBase.java:
##########
@@ -68,14 +68,17 @@ public class TrinoQueryITBase {
protected static final String metalakeName = "test";
protected static GravitinoMetalake metalake;
- private static void setEnv() throws Exception {
+ private static AbstractIT abstractIT;
+
+ private void setEnv() throws Exception {
+ abstractIT = new AbstractIT();
Review Comment:
`TrinoQueryITBase` needs to start Gravitino server but it's not the subclass
of `AbstractIT`, so we'd need to create a new instance.
Why does it work before then?
The method `startIntegrationTest` before hand is a static method, so we can
use `AbstractIT#startIntegrationTest`
directly.
##########
spark-connector/spark-common/src/test/java/org/apache/gravitino/spark/connector/integration/test/sql/SparkQueryRunner.java:
##########
@@ -83,6 +84,7 @@ public SparkQueryRunner(SparkTestConfig sparkTestConfig) {
}
initSparkEnv();
+ abstractIT = new AbstractIT();
Review Comment:
see below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
