diqiu50 commented on code in PR #4996:
URL: https://github.com/apache/gravitino/pull/4996#discussion_r1797613036
##########
integration-test-common/src/test/java/org/apache/gravitino/integration/test/util/AbstractIT.java:
##########
@@ -58,61 +58,61 @@
import org.apache.gravitino.server.web.JettyServerConfig;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.TestInstance;
import org.junit.jupiter.api.extension.ExtendWith;
-import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.CsvSource;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.testcontainers.shaded.org.awaitility.Awaitility;
@ExtendWith({PrintFuncNameExtension.class, CloseContainerExtension.class})
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
Review Comment:
Can this annotation be inherited by subclasses?
##########
integration-test-common/src/test/java/org/apache/gravitino/integration/test/util/AbstractIT.java:
##########
@@ -248,15 +248,8 @@ public static String startAndInitMySQLBackend() {
}
}
- @ParameterizedTest
- @CsvSource({
- "embedded, jdbcBackend",
- "embedded, kvBackend",
- "deploy, jdbcBackend",
- "deploy, kvBackend"
- })
Review Comment:
Would removing these have no effect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
