jerryshao commented on code in PR #5134:
URL: https://github.com/apache/gravitino/pull/5134#discussion_r1802851611
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java:
##########
@@ -102,10 +112,15 @@ public IcebergCatalogWrapper(IcebergConfig icebergConfig)
{
key -> catalogPropertiesToClientKeys.contains(key));
this.catalogPropertiesMap = icebergConfig.getIcebergCatalogProperties();
- }
- public IcebergCatalogWrapper() {
- this(new IcebergConfig(Collections.emptyMap()));
Review Comment:
We can still maintain this default constructor like:
```java
public IcebergCatalogWrapper() {
this(xxxx, false)
}
```
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
