jerryshao commented on code in PR #5134:
URL: https://github.com/apache/gravitino/pull/5134#discussion_r1802886595
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/provider/ConfigBasedIcebergCatalogWrapperProvider.java:
##########
@@ -75,7 +75,7 @@ public IcebergCatalogWrapper getIcebergTableOps(String
catalogName) {
LOG.warn(errorMsg);
throw new RuntimeException(errorMsg);
}
- return new IcebergCatalogWrapper(icebergConfig);
+ return new IcebergCatalogWrapper(icebergConfig, true);
Review Comment:
Why do we need to have a boolean to control whether to use credential
vending or not, is there any better way?
Also, I saw there're lot of hard-code value in this PR, if it is enabled by
default, maybe we can figure out a better way other than hard-coded boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
