jerryshao commented on code in PR #5127:
URL: https://github.com/apache/gravitino/pull/5127#discussion_r1804162490
##########
core/src/test/java/org/apache/gravitino/connector/TestCatalogOperations.java:
##########
@@ -198,17 +202,24 @@ public Table alterTable(NameIdentifier ident,
TableChange... changes)
throw new TableAlreadyExistsException("Table %s already exists",
ident);
}
} else {
- throw new IllegalArgumentException("Unsupported table change: " +
change);
+ // do nothing
Review Comment:
Because we need to handle columnChanges in the below code, so we should not
throw an exception.
##########
core/src/test/java/org/apache/gravitino/connector/TestCatalogOperations.java:
##########
@@ -198,17 +202,24 @@ public Table alterTable(NameIdentifier ident,
TableChange... changes)
throw new TableAlreadyExistsException("Table %s already exists",
ident);
}
} else {
- throw new IllegalArgumentException("Unsupported table change: " +
change);
+ // do nothing
Review Comment:
Because we need to handle columnChanges in the below code, so we should not
throw an exception here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
