mchades commented on code in PR #5127:
URL: https://github.com/apache/gravitino/pull/5127#discussion_r1804175692
##########
core/src/test/java/org/apache/gravitino/connector/TestCatalogOperations.java:
##########
@@ -198,17 +202,24 @@ public Table alterTable(NameIdentifier ident,
TableChange... changes)
throw new TableAlreadyExistsException("Table %s already exists",
ident);
}
} else {
- throw new IllegalArgumentException("Unsupported table change: " +
change);
+ // do nothing
Review Comment:
should change to:
```java
else if (!(change instanceof TableChange.ColumnChange)){
throw new IllegalArgumentException("Unsupported table change: " +
change);
}
```
because other table changes such as `UpdateComment` is not supported here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
