FANNG1 commented on code in PR #5134:
URL: https://github.com/apache/gravitino/pull/5134#discussion_r1804448008
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/provider/ConfigBasedIcebergCatalogWrapperProvider.java:
##########
@@ -75,7 +75,7 @@ public IcebergCatalogWrapper getIcebergTableOps(String
catalogName) {
LOG.warn(errorMsg);
throw new RuntimeException(errorMsg);
}
- return new IcebergCatalogWrapper(icebergConfig);
+ return new IcebergCatalogWrapper(icebergConfig, true);
Review Comment:
removed credential vending logic from `IcebergCatalogWrapper`, do
credential vending after related operation is finished outside.
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java:
##########
@@ -92,15 +95,27 @@ public Response listTable(
public Response createTable(
@PathParam("prefix") String prefix,
@PathParam("namespace") String namespace,
- CreateTableRequest createTableRequest) {
+ CreateTableRequest createTableRequest,
+ @HeaderParam(X_ICEBERG_ACCESS_DELEGATION) String accessDelegation) {
+ boolean isCredentialVending = isCredentialVending(accessDelegation);
LOG.info(
- "Create Iceberg table, namespace: {}, create table request: {}",
+ "Create Iceberg table, namespace: {}, create table request: {},
accessDelegation: {}, isCredentialVending:{}",
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
