FANNG1 commented on code in PR #5002: URL: https://github.com/apache/gravitino/pull/5002#discussion_r1805992450
########## iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/extension/IcebergEventLogger.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.iceberg.extension; + +import java.util.Map; +import org.apache.gravitino.listener.api.EventListenerPlugin; +import org.apache.gravitino.listener.api.event.Event; +import org.apache.gravitino.listener.api.event.PreEvent; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class IcebergEventLogger implements EventListenerPlugin { Review Comment: removed ########## core/src/main/java/org/apache/gravitino/GravitinoEnv.java: ########## @@ -130,21 +132,30 @@ public static GravitinoEnv getInstance() { } /** - * Initialize the Gravitino environment. + * Initialize base components, used for Iceberg REST server. * * @param config The configuration object to initialize the environment. - * @param isGravitinoServer A boolean flag indicating whether the initialization is for the - * Gravitino server. If true, server-specific components will be initialized in addition to - * the base components. */ - public void initialize(Config config, boolean isGravitinoServer) { - LOG.info("Initializing Gravitino Environment..."); + public void initializeBaseComponents(Config config) { + LOG.info("Initializing Gravitino base environment..."); this.config = config; + this.manageAllComponents = false; initBaseComponents(); - if (isGravitinoServer) { - initGravitinoServerComponents(); - } - LOG.info("Gravitino Environment is initialized."); + LOG.info("Gravitino base environment is initialized."); + } + + /** + * Initialize all components, used for Gravitino server. + * + * @param config The configuration object to initialize the environment. + */ + public void initializeAllComponents(Config config) { + LOG.info("Initializing Gravitino all Environment..."); Review Comment: updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
