FANNG1 commented on code in PR #5002: URL: https://github.com/apache/gravitino/pull/5002#discussion_r1807729653
########## iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/listener/api/event/IcebergRESTFailureEvent.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.listener.api.event; + +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.annotation.DeveloperApi; + +/** Represents an abstract failure event in Gravitino Iceberg REST server. */ +@DeveloperApi +public abstract class IcebergRESTFailureEvent extends FailureEvent { Review Comment: updated ########## iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/IcebergRestUtils.java: ########## @@ -71,4 +80,50 @@ public static Instant calculateNewTimestamp(Instant currentTimestamp, int hours) } return nextHourDateTime.atZone(ZoneId.systemDefault()).toInstant(); } + + public static String getCatalogName(String rawPrefix) { + String prefix = normalizePrefix(rawPrefix); + Preconditions.checkArgument( + !IcebergConstants.ICEBERG_REST_DEFAULT_CATALOG.equals(prefix), + String.format("%s is conflict with reserved key, please replace it", prefix)); Review Comment: updated ########## core/src/main/java/org/apache/gravitino/GravitinoEnv.java: ########## @@ -130,21 +132,30 @@ public static GravitinoEnv getInstance() { } /** - * Initialize the Gravitino environment. + * Initialize base components, used for Iceberg REST server. * * @param config The configuration object to initialize the environment. - * @param isGravitinoServer A boolean flag indicating whether the initialization is for the - * Gravitino server. If true, server-specific components will be initialized in addition to - * the base components. */ - public void initialize(Config config, boolean isGravitinoServer) { - LOG.info("Initializing Gravitino Environment..."); + public void initializeBaseComponents(Config config) { + LOG.info("Initializing Gravitino base environment..."); this.config = config; + this.manageFullComponents = false; initBaseComponents(); - if (isGravitinoServer) { - initGravitinoServerComponents(); - } - LOG.info("Gravitino Environment is initialized."); + LOG.info("Gravitino base environment is initialized."); + } + + /** + * Initialize all components, used for Gravitino server. + * + * @param config The configuration object to initialize the environment. + */ + public void initializeFullComponents(Config config) { + LOG.info("Initializing Gravitino full Environment..."); Review Comment: updated ########## iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/dispatcher/IcebergTableOperationDispatcher.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.iceberg.service.dispatcher; + +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.rest.requests.CreateTableRequest; +import org.apache.iceberg.rest.responses.LoadTableResponse; + +/** + * The {@code IcebergTableOperationDispatcher} interface defines the public API for managing Iceberg + * tables. + */ +public interface IcebergTableOperationDispatcher { + /** + * Creates a new Iceberg table. + * + * @param catalogName The catalog name when creating the table. + * @param namespace The namespace within which the table should be created. + * @param createTableRequest The request object containing the details for creating the table. + * @return A {@link LoadTableResponse} object containing the result of the operation. + */ + LoadTableResponse createTable( + String catalogName, Namespace namespace, CreateTableRequest createTableRequest); Review Comment: yes, will support the other table operations in another PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
