danhuawang commented on code in PR #87:
URL:
https://github.com/apache/gravitino-playground/pull/87#discussion_r1814116097
##########
init/gravitino/gravitino-dependency.sh:
##########
@@ -17,26 +17,22 @@
# specific language governing permissions and limitations
# under the License.
#
-# set -ex
-playground_dir="$(dirname "${BASH_SOURCE-$0}")"
-playground_dir="$(cd "${playground_dir}">/dev/null; pwd)"
-isExist=`which docker-compose`
-if [ $isExist ]
-then
- true # Placeholder, do nothing
-else
- echo "ERROR: No docker service environment found, please install
docker-compose first."
- exit
-fi
+gravitino_dir="$(dirname "${BASH_SOURCE-$0}")"
+gravitino_dir="$(
+ cd "${gravitino_dir}" >/dev/null
+ pwd
+)"
+. "${gravitino_dir}/../common/common.sh"
-components=""
-case "${1}" in
- *)
- components=$@
-esac
+# Prepare download packages
+if [[ ! -d "${gravitino_dir}/packages" ]]; then
+ mkdir -p "${gravitino_dir}/packages"
+fi
Review Comment:
I move the "# Prepare download packages" comment to the packages URL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
