xunliu commented on code in PR #87:
URL:
https://github.com/apache/gravitino-playground/pull/87#discussion_r1814399873
##########
docker-compose.yaml:
##########
@@ -106,40 +99,31 @@ services:
- "15432:5432"
volumes:
- ./init/postgres:/docker-entrypoint-initdb.d/
- deploy:
- resources:
- limits:
- cpus: "1"
- memory: 500M
mysql:
image: mysql:8.0
container_name: playground-mysql
+ environment:
+ - MYSQL_ROOT_PASSWORD=mysql
+ - MYSQL_USER=mysql
+ - MYSQL_PASSWORD=mysql
+ - MYSQL_DATABASE=db
ports:
- "13306:3306"
volumes:
- ./init/mysql:/docker-entrypoint-initdb.d/
- environment:
- MYSQL_ROOT_PASSWORD: mysql
- MYSQL_USER: mysql
- MYSQL_PASSWORD: mysql
- MYSQL_DATABASE: db
command:
--default-authentication-plugin=mysql_native_password
--character-set-server=utf8mb4
--collation-server=utf8mb4_general_ci
--explicit_defaults_for_timestamp=true
--lower_case_table_names=1
- deploy:
- resources:
- limits:
- cpus: "1"
- memory: 500M
healthcheck:
- test: ["CMD-SHELL", "mysqladmin ping -h localhost -p
${MYSQL_ROOT_PASSWORD}"]
+ test: ["CMD-SHELL", "mysqladmin ping -h localhost -pmysql"]
Review Comment:
I think better use ${MYSQL_ROOT_PASSWORD}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
