shaofengshi commented on code in PR #5117: URL: https://github.com/apache/gravitino/pull/5117#discussion_r1824234019
########## docs/cli.md: ########## @@ -109,7 +148,49 @@ gcli metalake list #### Show a metalake details ```bash -gcli metalake details --metalake metalake_demo +gcli metalake details --metalake metalake_demo +``` + +#### Create a metalake + +```bash +gcli metalake create --metalake my_metalake --comment "This is my metalake" +``` + +#### Delete a metalake + +```bash +gcli metalake delete --metalake my_metalake +``` + +#### Rename a metalake + +```bash +gcli metalake update --metalake metalake_demo --rename demo +``` + +#### Update a metalake's comment + +```bash +gcli metalake update --metalake metalake_demo --comment "new comment" +``` + +#### Display a metalake's properties + +```bash +gcli metalake properties --metalake metalake_demo +``` + +#### Set a metalake's property + +```bash +gcli metalake set --metalake metalake_demo --property test --value value Review Comment: I feel that "set-property" and "remove-property" are easier to understand, although they are longer. Say, except "property", Gravitino now supports "tag", which also have set-tag and remove-tag action. Please think about this, because once released, we may not easily change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
