mchades commented on code in PR #5354: URL: https://github.com/apache/gravitino/pull/5354#discussion_r1828647646
########## clients/client-python/gravitino/api/decimal.py: ########## @@ -0,0 +1,59 @@ +from decimal import Decimal as PyDecimal, ROUND_HALF_UP +from typing import Union +from .types import Types + + +class Decimal: Review Comment: Here is the reason why we need to wrap Java `BigDecimal`: https://github.com/apache/gravitino/blob/6d05ec4b8bf278c2dd7a36af35589f07b220fcab/api/src/main/java/org/apache/gravitino/rel/types/Decimal.java#L27-L34 Does the `PyDecimal` have the same issue? ########## clients/client-python/tests/unittests/test_decimal.py: ########## Review Comment: miss license header ########## clients/client-python/gravitino/api/decimal.py: ########## Review Comment: missing license header -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
