SophieTech88 commented on code in PR #5354: URL: https://github.com/apache/gravitino/pull/5354#discussion_r1828673190
########## clients/client-python/gravitino/api/types.py: ########## @@ -0,0 +1,921 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from .type import ( + Type, + Name, + PrimitiveType, + IntegralType, + FractionType, + DateTimeType, + IntervalType, + ComplexType, +) + + +class Types: + + class NullType(Type): + _instance = None + + @classmethod + def get(cls): + if cls._instance is None: + cls._instance = cls() + return cls._instance Review Comment: Thank you for catching that! You’re absolutely correct—this implementation does not currently handle race conditions, and under high concurrency, there’s a chance multiple threads could attempt to create the singleton instance simultaneously, breaking the singleton pattern. Solution: Adding Thread Safety with a Lock To handle this, we can use threading.Lock, which ensures that only one thread can enter the critical section where the instance is created. Here is the example: ``` class template: _instance = None _lock = threading.Lock() # A lock to ensure thread safety @classmethod def get(cls): with cls._lock: # Ensures only one thread can access this block at a time if cls._instance is None: cls._instance = cls() return cls._instance ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
