jerryshao commented on code in PR #5597:
URL: https://github.com/apache/gravitino/pull/5597#discussion_r1845938176


##########
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystem.java:
##########
@@ -559,6 +563,19 @@ public long getDefaultBlockSize(Path f) {
     return 
context.getFileSystem().getDefaultBlockSize(context.getActualFileLocation());
   }
 
+  @Override
+  public Token<?>[] addDelegationTokens(String renewer, Credentials 
credentials) {
+    List<Token<?>> tokenList = Lists.newArrayList();
+    for (FileSystem fileSystem : internalFileSystemCache.asMap().values()) {

Review Comment:
   Shall we filter out some filesystems that doesn't have delegation token 
mechanism? For example, like local filesystem, S3, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to