Re: [PR] [#5596] Improvement(filesystem-hadoop3): Override the `addDelegationTokens` method to fix the token expired issue [gravitino]

Mon, 18 Nov 2024 07:11:20 -0800 


xloya commented on code in PR #5597:
URL: https://github.com/apache/gravitino/pull/5597#discussion_r1845954154


##########
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystem.java:
##########
@@ -559,6 +563,19 @@ public long getDefaultBlockSize(Path f) {
     return 
context.getFileSystem().getDefaultBlockSize(context.getActualFileLocation());
   }
 
+  @Override
+  public Token<?>[] addDelegationTokens(String renewer, Credentials 
credentials) {
+    List<Token<?>> tokenList = Lists.newArrayList();
+    for (FileSystem fileSystem : internalFileSystemCache.asMap().values()) {

Review Comment:
   I think we don't need to do filtering, please see the specific code call:
   
![image](https://github.com/user-attachments/assets/9097751d-e12e-4465-a79b-0b8f4cce92d4)
   
![image](https://github.com/user-attachments/assets/cbc0e323-77cf-4fb4-8006-bdbdd645e60a)
   
![image](https://github.com/user-attachments/assets/9c681db1-c372-4a27-b8aa-324caa2d51a8)
   
![image](https://github.com/user-attachments/assets/c3f0c147-5f0d-47bc-8690-e81c44ddcde7)
   1. The `getCanonicalServiceName` and `getChildFileSystems` methods will 
always return `false` in the default implementations.
   2. Some FileSystems do not support token will also override the 
`getCanonicalServiceName` to return `null` directly(like S3AFileSystem, 
AliyunOSSFileSystem)
   
![image](https://github.com/user-attachments/assets/fd8cbc52-a6eb-4ead-b4cc-b56d53f298ab)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to