jerryshao commented on code in PR #5293: URL: https://github.com/apache/gravitino/pull/5293#discussion_r1849474586
########## docs/cli.md: ########## @@ -506,6 +507,26 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Owners commands + +#### List an owner + +```bash +gcli catalog details --name postgres --owner +``` + +#### Set an owner to a user + +```bash +gcli catalog set --name postgres --user admin Review Comment: I was thinking about the set action, what is the subject for "set" action? For example, you choose the subject "catalog" for set owner action `gcli catalog set --owner --name xxx --user yyy`. But for the set tag action, you choose "tag" subject for set as you mentioned above, shall we also use "catalog" subject? Basically, we can have two choices: 1) ``` gcli catalog set --owner --name xxx --user yyy gcli catalog set --tag --name xxx --tag-list aa,bb,cc ``` 2) ``` gcli owner set --name xxx --user yyy gcli tag set -- name xxx --tag-list aa,bb,cc ``` First thing is that we should be consistent for all the set action, second thing is that we should choose a easy-to-use way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
