justinmclean commented on code in PR #5293: URL: https://github.com/apache/gravitino/pull/5293#discussion_r1849547143
########## docs/cli.md: ########## @@ -506,6 +507,26 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Owners commands + +#### List an owner + +```bash +gcli catalog details --name postgres --owner +``` + +#### Set an owner to a user + +```bash +gcli catalog set --name postgres --user admin Review Comment: For `gcli tag set --tag tagA --name postgres` you are setting a tag on the postgres entity, and the command almost reads like an English sentence. That sentence is an imperative sentence, so the subject is implicitly you. The disadvantage with the form `gcli catalog set --tag ...` is that you explicitly need to set the entity type, which is not really needed. Why make the user type more and have to think about the entity type as well? I initially considered doing the same with the owner command, but owner is not really an entity on its own like a metalake or tag. It's more of an attribute of an entity, which is why I didn't put the commands in the same form. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
